-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cooldown Maintenance] Added More Spells #46
Conversation
Added Essence Break (Havoc Demon Hunter) Added Touch of the Magi (Arcane Mage)
Added Shifting Power (Mage)
I might be wrong here, but I think the cooldown time threshold to include cooldowns of type 1 (attack cooldowns) is 60 seconds. |
Okay, after some more testing... Touch of the Magi shows correctly until CDR is used (for example, Shifting Power), the update in time then works but the ability automatically hides afterwards - as you can see here. Essence Break shows correctly once being used but conditions are not updated once the spell has returned off cooldown. I am using Echo Raid Tools, a simple desaturation is added when the spell is on cooldown and then the desaturation is removed on the ability being available to use but this seems to not be the case on Essence Break. Happy to wait for this merge, as more spells are not working. Would reducing the minimum cooldown be possible? TL;DR - Minimum CD Threshold for Attack Cooldowns is definitely 60. |
The questions for this issue are:
|
Definitely for arenas, if people find that useful but I would assume most people are looking to mimic the functionality that is provided by OmniCD but might prefer Echo Raid Tools (as I do).
Completely understand this, and ultimately, it won't be for every use case, I tend to only track the main offensive cooldowns (2mins or more) but Touch of the Magi is a pretty important cooldown as far as burst goes, so that might be useful to track. |
Hi, found a solution. |
I am happy to do that but out of interest, how does this solve the CD durations between less than a minute? Won't tracking still be an issue? |
Hi! |
Sorry for not updating this. I will do some testing soon (university is manic). Just out of interest, how does tracking work for Blessing of Freedom, this is a 25s CD but works effectively for tracking. There are a few spells that I'd like to add but the CD limit being 1min is causing some issues, I appreciate this should be fixed for |
Communication on this pr has been made with smoke signals :D |
Added: